search

diaspora / diaspora-project-site

Code for the Diaspora project site.
https://diasporafoundation.org/
Other
48 stars 41 forks source link

Diasporafoundation.org internal server error #98

Closed anuyts closed 7 years ago

anuyts commented 7 years ago

The website diasporafoundation.org has a language menu. When I pick "Nederlands", I get an internal server error (500). Because the language setting is not stored in the URL, going back without language menu seems impossible, and the menu is gone. To be clear: the primary problem is not that the translation is missing, but that you cannot go back. First filed here.

goobertron commented 7 years ago

Related to #97. This should have been fixed by fa7ef2e and fdd29e2. @denschub, looks like there's a but more fixing needed, I'm afraid.

denschub commented 7 years ago

looks like there's a but more fixing needed, I'm afraid.

Well, that's the fun of replacing placeholders inside translations. There is nothing I can do, this has to be fixed on WTI for all locales.

goobertron commented 7 years ago

I thought locales were supposed to fall back to another language (ultimately to English) if there was not a translation for a particular string. It's not good if a missing translation breaks the entire site. Is there no way around that?

As a last resort, and if there's not a better means of coping with missing strings, how about adding empty strings ("") to the locale files where there is not (yet) a translation?

denschub commented 7 years ago

It's not good if a missing translation breaks the entire site. Is there no way around that?

It's not a missing translation, it's the mere fact the placeholder poduptime doesn't exist anymore since it was removed.

denschub commented 7 years ago

Deployed a ghetto hack since it's breaking the index page and I don't have the time to go through all translations.

Flaburgan commented 7 years ago

I think @cmrd-senya checked all the index page on saturday evening and only Nertherland was broken (can you confirm senya?)

denschub commented 7 years ago

I can confirm that, since I just used some grep and sed magic. That's why I already removed the ghetto hack and purged the Dutch translation of that key. ;)

goobertron commented 7 years ago

Thanks very much indeed, @denschub, for your work on this!