search

diaspora / diaspora

A privacy-aware, distributed, open source social network.
https://diasporafoundation.org/
GNU Affero General Public License v3.0
13.41k stars 2.92k forks source link

Tags with special characters (eg hyphens) are treated as separate tags #4701

Open Bugsbane opened 10 years ago

Bugsbane commented 10 years ago

If someone does a search for #hash-tag they get shown different results to if they search for #hashtag.

There is already user discussion around this issue over at: https://joindiaspora.com/posts/3531831

I imagine this would also apply to things like apostrophe's (eg #Hawai'i vs #Hawaii)

I propose that internally, all hashtags be stripped of non alphanumeric characters, to prevent hashtag duplication in the database and help users see all of the posts they would expect to.

Theo-Neandonly commented 10 years ago

I second that motion!

I've always got an eye on efficiency and conservation of resources in computing, and this measure would save servers and clients time, effort, bandwidth, and processing power, as well as provide a better experience to the end-user.

goobertron commented 10 years ago

This is something which needs discussion before implementation, which we do on Loomio rather than Github. There is already mention of this, for example in this discussion. Look forward to your contributions.

aka001 commented 9 years ago

I am new to diaspora. I want to work on this issue. Can someone please help me in getting started?

jaywink commented 9 years ago

This proposal describes how things should work.

It would be awesome @aka001 if you want to start working on this. Are you experienced with Ruby on Rails?

Anyway, to start hacking on the code, you will first need to fork the code and set up a development instance on your computer. See this wiki entry for install guides. We have also a page relating to working with git here.

A good way to get help is to join #diaspora-dev on FreeNode IRC - there is always someone there to help usually :) You can also ask here for pointers if you feel lost on how to start.

aka001 commented 9 years ago

@jaywink Thank you for such a quick reply. I have previously done a project in Ruby on Rails: https://github.com/aka001/HospitalManagementSystem . I have also forked the repository and started setting up the project using this link: https://wiki.diasporafoundation.org/Installation/Ubuntu/Trusty I have worked with git before. I will follow the proposal and create a pull request for this issue soon.

Flaburgan commented 9 years ago

On a side note, you also probably want to read our testing workflow ;)