search

diaspora / diaspora

A privacy-aware, distributed, open source social network.
https://diasporafoundation.org/
GNU Affero General Public License v3.0
13.4k stars 2.92k forks source link

Desktop ignore button toggling shows wrong state #7892

Open HankG opened 6 years ago

HankG commented 6 years ago

I ran across this bug while testing a feature. On the desktop app toggling between ignoring a user and not does not preserve the correct state. When a user ignores/blocks another one any aspects they are in are removed. If I immediately undo the block without refreshing however it shows the original aspects the user was in. On refresh it shows the correct state. For example:

  1. Before ignoring: image

  2. After ignoring: image

  3. After reverting the ignore but before refreshing: image

  4. After refresh: image

I'm pretty sure I know how I'd change this to make it consistent, basically a change trigger is probably not being picked up along the way and causing the service populating the drop down to refresh correctly. I'm not actively working but if someone would like to add this to the #hacktoberfest this could be an interesting low hanging bug to pick up.

HankG commented 6 years ago

I've tested this on the Mobile version coded in PR #7884 against Issue #7840 and the behavior is correct there (the code is all Rails versus Rails and JavaScript so the discrepancy is not necessarily surprising).

Flaburgan commented 6 years ago

I tag this as a bug but with low priority imo.