Make height and width optional for photos

diaspora / diaspora_federation

A library that provides functionalities needed for the diaspora* federation protocol.

GNU Affero General Public License v3.0

101 stars 29 forks source link

Make height and width optional for photos #76

Closed SuperTux88 closed 7 years ago

SuperTux88 commented 7 years ago

This is needed to fix profile exports, see here.

SuperTux88 commented 7 years ago

You are right, it's a good idea to use the new optional flag. There is a special case for arrays where it needs to be an empty array (an not nil) even when it's optional (photos in StatusMessage), so I added a check to not ignore not_nil rules.

I also added a commit to removed the nilable parameter from the guid rule, because we can use the optional flag there too.

cmrd-senya commented 7 years ago

Merged, thanks! :cookie: :cookie: :cookie: