search

diaspora / diaspora_federation

A library that provides functionalities needed for the diaspora* federation protocol.
GNU Affero General Public License v3.0
101 stars 29 forks source link

Fix when booleans in relayables are false #90

Closed SuperTux88 closed 6 years ago

SuperTux88 commented 6 years ago

This was a problem with dislikes.

It's safe to use to_s here, because we have only strings, numbers and booleans here anyway, because relayables don't support nested entities. to_s is used to generate the signature_data string too.

https://github.com/diaspora/diaspora_federation/blob/7503e9a804ea2ccf27ad7edb70da42b6870a548f/lib/diaspora_federation/entities/relayable.rb#L161-L164

cmrd-senya commented 6 years ago

Merged, thanks :cookie: