search

diaspora / jsxc

Real-time chat app
www.jsxc.org
Other
22 stars 16 forks source link

Git submodules should be changed to bower packages #62

Open dimaursu opened 9 years ago

dimaursu commented 9 years ago

There's no point in having 2 ways of managing dependencies: "i18next" and "otr" have bower packages, with these names. "stophe.jingle" doesn't, the package in bower is way older. (It's the original repo, not the one forked by sulko)

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/7447801-git-submodules-should-be-changed-to-bower-packages?utm_campaign=plugin&utm_content=tracker%2F7153406&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F7153406&utm_medium=issues&utm_source=github).
zauberstuhl commented 9 years ago

agree with i18next.

after I wrote you on diaspora I remembered why I haven't moved otr and strophe to bower; sulko touched the code.

but it is still a valid point. let me think about it, maybe we find a proper solution for this.

pravi commented 9 years ago

how about jquery and plugins? Since they are already served via rails-assets.org as gems, why do we have to embed them? gemspec already has those dependencies. sprockets will find them anyway.

pravi commented 8 years ago

Any plans for fixing this?

pravi commented 8 years ago

@Zauberstuhl can we at least remove minified js from jsxc.dep.js immediately? Currently strophe.min.js is used in jsxc.dep.js. Also can you document how this file is created (which are the dependencies used)? This is blocking diaspora package update to 0.6.0.0 in debian.

pravi commented 8 years ago

Also why do we need to create jsxc.dep.js? Doesn't assets:precompile step do concatenation already?

zauberstuhl commented 8 years ago

All dependencies with the correct license is documented here https://github.com/diaspora/jsxc/blob/develop/dep.json

Why is it blocking th debian package release?

Doesn't assets:precompile step do concatenation already?

Many stuff is not available in rails assets or cannot be used via the assets pipeline (e.g. web worker)

pravi commented 8 years ago

On 2016, സെപ്റ്റംബർ 26 4:10:45 PM IST, Lukas Matt notifications@github.com wrote:

All dependencies with the correct license is documented here https://github.com/diaspora/jsxc/blob/develop/dep.json

Thanks, I will check this.

Why is it blocking th debian package release?

Because minified files are not considered source code and every binary should have its corresponding source code.

So we minify the non-minified source during package build.

I think jsxc upstream has the non-minified jsxc.dep.js I'll try to take it from there directly.

Doesn't assets:precompile step do concatenation already?

Many stuff is not available in rails assets or cannot be used via the assets pipeline (e.g. web worker)

Is it true for all remaining dependencies?

zauberstuhl commented 8 years ago

I think jsxc upstream has the non-minified jsxc.dep.js I'll try to take it from there directly.

not only upstream -> https://github.com/diaspora/jsxc/blob/develop/build/jsxc.dep.js

Is it true for all remaining dependencies?

haven't checked. OTR and webworker is the first thing which comes to my mind.

pravi commented 8 years ago

@Zauberstuhl can't we use rails-assets-jsxc directly? Though their bower package is not yet updated to 3.0 https://github.com/jsxc/jsxc/issues/371

pravi commented 8 years ago

not only upstream -> https://github.com/diaspora/jsxc/blob/develop/build/jsxc.dep.js

No, that uses strophe.min.js, see and compare https://raw.githubusercontent.com/jsxc/jsxc/master/build/lib/jsxc.dep.js

which uses strophe.js (non minimized).

zauberstuhl commented 8 years ago

can't we use rails-assets-jsxc directly

unfortunately no, the dependencies are broken: https://github.com/jsxc/jsxc/blob/master/bower.json#L30