diaspora / jsxc

Real-time chat app
www.jsxc.org
Other
22 stars 16 forks source link

[WIP] Buddy name in conversation window brings to buddy home page #77

Closed ghost closed 9 years ago

ghost commented 9 years ago

Related to #75.

jhass commented 9 years ago

Maybe try to separate out the whitespace changes into a distinct commit :)

ghost commented 9 years ago

@jhass : Yeah, I tryed Atom as IDE this time, it removes trailing whitespaces. I comit again without this modification.

ghost commented 9 years ago

Can someone tell me how I can retrieve the home page of the displayed user ? À propos, @Zauberstuhl, JSXC has its own HTML escaping function

zauberstuhl commented 9 years ago

@AugierLe42e then use the function from jsxc. well for the current user you can do app.currentUser.expProfileUrl() maybe there is also a contacts-object. But I have to search on my own, too ;)

zauberstuhl commented 9 years ago

@AugierLe42e do you mind if I fix #78 ?

ghost commented 9 years ago

On JSXC or Vines ? On JSXC, it is done with this PR, here.

zauberstuhl commented 9 years ago

ok can you rebase and merge it if you are ready?

ghost commented 9 years ago

Nope, it's not finished yet :/ I still don't know how to get the profile page of the selected contact. This is the last thing needed to finish this. If you plan to make a release, I can move this specific change into another PR ?

ghost commented 9 years ago

@Zauberstuhl : can you review (not that I don't trust my code, just, to be sure :p) ?

ghost commented 9 years ago

Ok to merge ?

zauberstuhl commented 9 years ago

I'll review. I'll merge. No hurry :)

ghost commented 9 years ago

KTHXBYE :p