diasurgical / devilution

Diablo devolved - magic behind the 1996 computer game
Other
8.76k stars 919 forks source link

[Not A Bug] Question about the License and Legal Section in the Readme #2208

Closed pairofdocs closed 2 years ago

pairofdocs commented 3 years ago

Hello,

I was interested in this project, was looking around and noticed a conflict in the 'legal' docs. This is not a big issue for me I think that the most recent doc, the README, has more weight than the LICENSE file. Maybe this can be improved/ clarified.

https://github.com/diasurgical/devilution/blob/master/LICENSE#L3-L5 from 2018 Anyone is free to copy, modify, publish, use, compile, sell, or distribute this software ... for any purpose, commercial or non-commercial...

vs

https://github.com/diasurgical/devilution/blob/master/README.md#L120 https://github.com/diasurgical/devilution/blob/master/README.md#legal from 2020 The source code in this repository is for non-commerical use only. If you use the source code you may not charge others for access to it or any derivative work thereof.

Mentioning users who edited these lines (referencing git blame) @galaxyhaxz @AJenbo

P.S. Thank you for your work on devilution 🔥

galaxyhaxz commented 3 years ago

I originally released the project under no license (a.k.a Un-license) because I wasn't sure how to license the code. We later had clarification and decided to specify the code should not be used for commercial purposes since it is based on Blizzard's original code. More specifically devilution is a preservation of the original code under the interoperability clause, so technically it's being provided purely for academic/research purposes.

pairofdocs commented 3 years ago

Gotcha. Should the License file be updated so that the message is consistent with the Readme?

AJenbo commented 3 years ago

yes

TheEvilSkeleton commented 3 years ago

Any update?

AJenbo commented 2 years ago

This issue has now been resolved, thank you for the patience.