search

diasurgical / devilution

Diablo devolved - magic behind the 1996 computer game
Other
8.66k stars 921 forks source link

Farmer Quest Bug #2247

Closed vladtepesch closed 2 years ago

vladtepesch commented 2 years ago

as explored in https://github.com/diasurgical/devilutionX/issues/2578#issuecomment-897880228

the current farmer quest resets the quest to INIT after spawning the reward. The initial code Commit 14aab09 has a 10 at this place that also would make more sense since there also is a case 10.

I guess that this bug was added while replacing magic numbers by enum values.

Edit:

The incriminating commit: adf5f8f504236dc64624916b462ab9c0ad9ca0cb

yuripourre commented 2 years ago

As pointed by @vladtepesch, this is the line: https://github.com/diasurgical/devilution/commit/adf5f8f504236dc64624916b462ab9c0ad9ca0cb#diff-3032c1171c11f9fe079f56e3db22dfba40ed7fa09d358743ef583cbac9199933L1275