search

diasurgical / devilution

Diablo devolved - magic behind the 1996 computer game
Other
8.66k stars 921 forks source link

items: add BUGFIX for RndItem, invalid logic for Scroll of Resurrect #2258

Closed mewmew closed 1 year ago

mewmew commented 2 years ago

Scroll of Resurrect occurs twice in the item data list, firstly at IDI_RESURRECT with IDROP_NEVER, and secondly a regular item with IDROP_REGULAR.

Since the ri-- logic only checks for spell ID, ri will be decremented also for IDROP_NEVER; thus unintentionally removing the previously added valid item ID in Single Player (which is this case is always gold).

Therefore, the chance for gold drop is higher in Multi Player than Single Player.

mewmew commented 1 year ago

Anything else needed to merge this PR? :P