search

diasurgical / devilution

Diablo devolved - magic behind the 1996 computer game
Other
8.79k stars 919 forks source link

objects: add BUGFIX for InitObjects #2281

Closed mewmew closed 2 years ago

mewmew commented 2 years ago

Don't load objects from Blind2.DUN, as Blind2.DUN is missing an objects layer. This may results in an out-of-bounds read.

galaxyhaxz commented 2 years ago

Perhaps the real bug is that the DUN file should have a blank object layer inside it? It would seem inconsistent for each DUN file to be hardcoded with what it contains :P

AJenbo commented 2 years ago

But they are :D

galaxyhaxz commented 2 years ago

"Blizzard, it is your responsibility to program the HAL-9000 computer to watch over mankind during hibernation, our fate lies with you"

Breaking bad engaged...

mewmew commented 2 years ago

"Blizzard, it is your responsibility to program the HAL-9000 computer to watch over mankind during hibernation, our fate lies with you"

The 9000 series is the most reliable computer ever made. No 9000 computer has ever made a mistake or distorted information. We are by any practical definition of the words, fool-proof and incapable of error.

AJenbo commented 2 years ago

No 9000 for president!