search

diasurgical / devilutionX

Diablo build for modern operating systems
Other
8.03k stars 787 forks source link

[Enhancement proposal] Removing a selected skill or spell #1100

Closed Chance4us closed 3 years ago

Chance4us commented 3 years ago

I have not yet found a way to remove the selected spell or ability. It probably makes sense to add such a keyboard shortcut, doesn't it?

qndel commented 3 years ago

???

AJenbo commented 3 years ago

image

qndel commented 3 years ago

but ... why ... xD

Chance4us commented 3 years ago

How can I choose the empty square?

qndel commented 3 years ago

why would you do it? it's pointless

Chance4us commented 3 years ago

It makes sense to avoid accidentally consuming a scroll (for example town portal). Otherwise, when you play with the Barbarian you would have to select the rage skill. I personally don't want to use it either because it would permanently damage the max health.

Chance4us commented 3 years ago

So I would prefer removing a selected skill or spell by a shortcut or otherwise. What do you think about?

qndel commented 3 years ago

that's the most pointless thing I've ever heard of ;) what's next? ability to tell the difference between two identical healing potions? microtransactions? Horse armor? :D image

AJenbo commented 3 years ago

Shift-click the icon to set it to blank?

Chance4us commented 3 years ago

Shift-click which icon below? screen16

Chance4us commented 3 years ago

Savegame for testing: single_0.hsv.zip

malvarenga123 commented 3 years ago

Off-topic: This reminds me of the follower skills in Diablo 3. Once you choose one, there's no coming back. The only way to have a follower without selected skills is to create a new character.

AJenbo commented 3 years ago

Shift-click which icon below?

It was a suggestion as to how this could be implemented, not saying that it is already there.

Chance4us commented 3 years ago

There is a way to remove the selected spell or ability. But then you have to drop all the scrolls. I was expecting our masters to see this as an improvement in usability, too. But it doesn't matter at first, I have even more suggestions. ;-)

Chance4us commented 3 years ago

@AJenbo It could be also offered an empty box to click, or a keyboard shortcut or several possibilities at the same time.

AJenbo commented 3 years ago

You can also do it by removing a staff with an active spell.

AJenbo commented 3 years ago

@Chance4us you can now clear it with shift+click: https://github.com/diasurgical/devilutionX/pull/1106/commits/b34296a4359cc8aee6d3b6dd9b7a3c0f18e573dd

Chance4us commented 3 years ago

Really nice. I hope qndel will like it in the future too.

qndel commented 3 years ago

I can't see myself ever using it :shrug:

Chance4us commented 3 years ago

@qndel You are still completely okay. ;-)