[SDL1] Scrolling text in conversations is drawn over UI

[Medard22]

Important information Open Dingux Beta v2021-10-15/ 1.3.0 / downloaded from github

Describe I tried the latest build on my RG-350M. When talking to NPC the scrolling text draws over all UI elements at the bottom of the screen. Parts of the text are stuck on the UI making it unreadable. Using a potion from the quick slot will refresh the UI, but the problem will return with the next conversation. It looks like some kind of Z ordering issue. See the screenshots below, sorry for the crappy picture quality. I am not sure if it´s a common issue in all OpenDingux devices, or if it´s present only on RG-350M (this one has a 640x480 screen, while others have mostly 320x240 screen).

Before this release I was using a custom opk built from source from here: https://boards.dingoonity.org/ingenic-jz4760-devices/devilutionx-for-opendingux-beta/

It was posted at the end of June, and while it was buggy, this particular bug was not present in this build. So it´s most likely a regression that was introduced in the past couple of months. I can help with testing if necessary.

Screenshots

[qndel]

I'd risk saying it's present only on 640x480 because this resolution is the only one that doesn't redraw UI

[AJenbo]

There is defiantly a general issue with the SDL1 backend:

The main panel is only affected at 640x480, but probably would not be an issue if the other one is solved.

[glebm]

Updated OPKs (built from master @ 117695489b19e24955c32803c22f48880ac3eb14): devilutionx-rg350.opk.zip devilutionx-retrofw.opk.zip devilutionx-lepus.opk.zip devilutionx-gkd350h.opk.zip

[Medard22]

Thank you for the updated packages. The bug is fixed now. There are some minor occasional flashes of text here and there, but that seems to be another issue. Now the game is perfectly playable. Thank you and the team for the quick fix ^^b

On Fri, 5 Nov 2021 at 16:15, Gleb Mazovetskiy @.***> wrote:

Updated OPKs: devilutionx-rg350.opk.zip https://github.com/diasurgical/devilutionX/files/7487002/devilutionx-rg350.opk.zip devilutionx-retrofw.opk.zip https://github.com/diasurgical/devilutionX/files/7487006/devilutionx-retrofw.opk.zip devilutionx-lepus.opk.zip https://github.com/diasurgical/devilutionX/files/7487009/devilutionx-lepus.opk.zip devilutionx-gkd350h.opk.zip https://github.com/diasurgical/devilutionX/files/7487012/devilutionx-gkd350h.opk.zip

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/diasurgical/devilutionX/issues/3388#issuecomment-961980364, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKHI7UK2BXMY5UO47AQXIZLUKPYHHANCNFSM5HL2DTAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[glebm]

@Medard22 The other issue is now also fixed! OPK: https://github.com/diasurgical/devilutionX/releases/download/1.3.0/devilutionx-rg350.opk

[Medard22]

Tested and it works perfectly now :) Many thanks. You are awesome!