diasurgical / devilutionX

Diablo build for modern operating systems
Other
7.99k stars 781 forks source link

Inconsistent collision/solid tiles on house edges #3487

Open ephphatha opened 2 years ago

ephphatha commented 2 years ago

Important information Vanilla Diablo/Hellfire

Describe Tiles used to make the edge of houses are not consistently marked solid or blocking, letting the player stand in places that look odd or get blocked from places it looks like they should be able to walk.

Expected behavior 2021-11-13T231733_Diablo 2021-11-13T233628_devilutionx I'd expect consistent flagging of tiles other than the barrel, either the corner of the house should also be solid or the tiles with greenery, the path to the door, and the other corner should be non-solid (assuming this one was a workaround for rendering issues).

2021-11-13T231750_Diablo 2021-11-13T233649_devilutionx The right corner is non-solid and non-blocking, this should be solid and blocking to match the rest of the tiles on this side of the house.

2021-11-13T231817_Diablo 2021-11-13T233720_devilutionx The line of shadow on this house is marked as solid, either the half-shadow on the corner should also be solid or the shadow tiles should be non-solid.

2021-11-13T231927_Diablo 2021-11-13T233809_devilutionx Same thing for the barmaids house.

2021-11-13T232010_Diablo 2021-11-13T233903_devilutionx And for the beggar.

2021-11-13T231907_Diablo 2021-11-13T233740_devilutionx The tile southeast of the barrels at the tavern is visually clear, should probably be non-solid (again suspect this was a workaround for rendering issues given the tile has greenery on it).

2021-11-13T231942_Diablo 2021-11-13T233842_devilutionx The tile northeast of pepins door is marked as solid, probably to prevent rendering issues again.

The northwest part of the cathedral garden (where the light shines out of the windows) is a complete mess for pathing as well. Most of the illuminated tiles are marked as solid, I guess so that they didn't have to mimic casting light on the player character. I didn't bother with screenshots since it's so far out of the way.

Additional context Honestly not sure if this is desirable to change, it'd require modifying the solid table after loading the SOL file from the MPQ.

qndel commented 2 years ago

Actually don't rely on debug data when it comes to houses - it might be inaccurate - use "grid" command to see where the grid is missing, no data is being displayed there at all