diasurgical / devilutionX

Diablo build for modern operating systems
Other
8.06k stars 793 forks source link

misc.cpp - CreateFileMappingA #42

Closed VonKossa closed 5 years ago

VonKossa commented 5 years ago

Hi!

After compiling experimental 64bit version i get the following when running devilutionx binary. Known problem or something i do wrong?

DUMMY: CreateFileMappingA @ /devilutionX-master/SourceX/miniwin/misc.cpp:588 devilutionx: /devilutionX-master/SourceX/miniwin/misc.cpp:589: void* dvl::CreateFileMappingA(dvl::HANDLE, dvl::LPSECURITY_ATTRIBUTES, dvl::DWORD, dvl::DWORD, dvl::DWORD, dvl::LPCSTR): Assertion `hFile == (HANDLE)-1' failed. Aborted

AJenbo commented 5 years ago

What platform and compiler are you using? Both the Mac and Linux (Debian) builds are passing for 64bit so I would say this is unexpected.

VonKossa commented 5 years ago

Gentoo Linux x86-64 cmake 3.14.0 Gnu Make 4.2.1 GCC 8.2.0

VonKossa commented 5 years ago

I also tested to delete devilution directory under .local/share

AJenbo commented 5 years ago

@VonKossa could you give it another try, I'm not sure it's fixed, but might be.

VonKossa commented 5 years ago

Same problem. I configured it with this flag before compiling it if it has something to do with it: cmake -DDEBUG=OFF ..

AJenbo commented 5 years ago

This should now be fixed. You may also want to run it with -DBINARY_RELEASE=ON (this will disable all debugging)