diasurgical / devilutionX

Diablo build for modern operating systems
Other
8.06k stars 794 forks source link

Suggestions #518

Closed inukaze closed 4 years ago

inukaze commented 4 years ago

Hi there again xD, i want to say some suggestions, basically Exclusive Options of DevilutionX (i hope) well, my ideas are the follow (i don't know if some of this are right now available in DevilutionX 0.5.0) :

1 - Like in Diablo 2, Press ALT to show items on the floor, because sometimes its really hard to see if i leave some important item on the floor, on a very dark dungeon and lot of enemies corpses.

2 - Like in Diablo 2, Press F1~10 to Assing Fast Spell change

3 - Remove password ask in Intranet Gameplay [i think it unnecesary for example on Intranet Gameplay]

4 - Option for Detect Running gameplay on Intranet, and show a list of server, [just for not put manually IP] something like

| Server Name | Intranet/Internet Address | Ping | Req Pass

1 | Inukaze | 192.168.1.2 | 50 | No

5 - Add an icon for DevilutionX, i notice windows binary executable don't had none xD another thing i notice in windows 7 x64, using DevilutionX 0.5.0, some text inside the game was on Spanish. [ i apply patch on my normal disable game for translate text to spanish, but i don't know if that modify mpq or exe file or both ]. well icon in png & ico format xD

Well i think you need to add new menu entry can be "Options -> DevilutionX" and there

Show dropped items : Toggle / Always (If Toggle assign a key, default ALT) Multiplayer Password : Ask Always / Never Ask / Ask if not Intranet Game Fullscreen : Yes / No Upscale Size : [Integer Number] Scaling Quality : Low / Med / High Grab Input : Yes / No

And well that are the things can be improve the gameplay and make the differences with original engine options.

AJenbo commented 4 years ago

1 - Like in Diablo 2, Press ALT to show items on the floor, because sometimes its really hard to see if i leave some important item on the floor, on a very dark dungeon and lot of enemies corpses.

We do not plan to change the game play, things like that will probably be left up to other mods. That beeing said we might have it as a common set of patches that can easily be applied. And also Hellfire added a similar feature so once we land Hellfire support (81% done) it will be available.

2 - Like in Diablo 2, Press F1~10 to Assing Fast Spell change

F5-F8 already behaves in this way.

3 - Remove password ask in Intranet Gameplay [i think it unnecesary for example on Intranet Gameplay]

We can't really tell internet and intranet apart, and the same game maybe be available via both. Maybe once we feel we have closed most of the original security holes we might add and option not to have it password protected and or encrypted (you can edit it out in source pretty easily if you feel ok taking the risk).

4 - Option for Detect Running gameplay on Intranet, and show a list of server, [just for not put manually IP] something like

We are working on a solution, but it's a long term goal. First version would just be a list of games by name. Eventually we might reuse the Battle.net UI to show level and ping and possibly other information, or maybe something completely different, the future isn't quite clear on this one yet :) image

5 - Add an icon for DevilutionX

It's probably relatively simple to do with CMake but I haven't really bothered looking in to it since it's Windows specific, feel free to send a patch :) (p.s "don't had none" is a double negative, meaning "it's does")

some text inside the game was on Spanish. [ i apply patch on my normal disable game for translate text to spanish, but i don't know if that modify mpq or exe

I don't know what you did, but if it was a patch for the original game then it doesn't understand the new exe so would be done either via Patch_rt.mpq or some other means. Some text is also pulled from your operating system (error messages) so they will appear in your local language with no need for translation.

Well i think you need to add new menu entry can be "Options -> DevilutionX" and there

I think we talked about this earlier, until 1.0.0 we are sticking pretty strictly to how the feel was in Diablo 1.09, also we do not want to expose options for things that aren't fully dynamic. As such an option menu is out of scope for now, but will defiantly land at a later point.

And well that are the things can be improve the gameplay and make the differences with original engine options.

I'm not sure I understand, my guess is that you say that we should add anything that we add - that wasn't in the original game?

AJenbo commented 4 years ago

Closing as it contains multiple issues and most of it is out of scope for now. Maybe a better way to talk about ideas like this would be on our Discord chat (link is in the read-me).

This issue is almost the exact example from https://softwareengineering.stackexchange.com/questions/203998/why-it-is-not-recommended-to-post-several-defects-in-the-same-issue-ticket

:)

inukaze commented 4 years ago

Thanks for the quick answers.

AJenbo commented 4 years ago

An icon has now been added for Windows builds https://github.com/diasurgical/devilutionX/commit/297e98e8487b79c0016226b4c97da071b32e50cb

inukaze commented 4 years ago

Thank you very much :D

Dunno, in a future release, you plan to add launcher like Torchlight 2, for custom which mods be enable before start game ?

i forget mention i had uploaded my compiled versions of devilutionx-0.5.0 for 32 Bits & 64 Bits, compile against Slackware 14.2 & Slackware64 14.2. I had include my own bash scripts (2 scripts, the first "jugar.sh" to try to use system libraries, and the second "altjugar.sh" to try use the libraries i had included)

If you want to try you can download from here -> https://www.mediafire.com/file/pc3vvrf37dddl26/DevilutionX-0.5.0.7z/file

i had test on multiple Live distro, like Lubuntu 16.04 and for me works fine. well except the versions for the Spawned version, because just starting give me a segmentation fault on any distro can run, in both architectures. and well i don't remember if i can include spawn.dat without legal problems.

AJenbo commented 4 years ago

Dunno, in a future release, you plan to add launcher like Torchlight 2, for custom which mods be enable before start game ?

We would need meaning full mod support before that would be relevant, personally i don't really like launchers, it's an extra step that every one will have to go through but not every one will use. So I would think a game menu would be a better option. Still it's to early to know where we will go with that.

i had test on multiple Live distro, like Lubuntu 16.04 and for me works fine. well except the versions for the Spawned version, because just starting give me a segmentation fault on any distro can run, in both architectures. and well i don't remember if i can include spawn.dat without legal problems.

I'm not sure what you are asking here, do you want me to test something for you? Are you suggesting that we use Slackware to build releases?

inukaze commented 4 years ago

Dunno, in a future release, you plan to add launcher like Torchlight 2, for custom which mods be enable before start game ?

We would need meaning full mod support before that would be relevant, personally i don't really like launchers, it's an extra step that every one will have to go through but not every one will use. So I would think a game menu would be a better option. Still it's to early to know where we will go with that.

That answer make me think you had planned to make something similar to engine "DarkPlaces" for Quake, when you had the gamedata, and start DarkPlaces, inside the options, exist a easy way to enable mods

Look "Browse Mods" inside the "Options" Menu 000

Inside the "Browse Mods" in this case took all directories, and well i think is bad idea, for its be better make a folder called "mods" and put directories & files inside of them 001

Well you can switch which mod(s) you can enable just pressing left or right arrows, and for apply just press enter to activate 002

And when the mod its activated, in this case change to a total conversion mod 003

i had test on multiple Live distro, like Lubuntu 16.04 and for me works fine. well except the versions for the Spawned version, because just starting give me a segmentation fault on any distro can run, in both architectures. and well i don't remember if i can include spawn.dat without legal problems.

I'm not sure what you are asking here, do you want me to test something for you? Are you suggesting that we use Slackware to build releases?

Well i asking if you can test my precompiled version :D just to see if work fine with system libs or with the libs i had include.

Well the another thing, no, i am not suggesting that, on my case i prefer use Slackware 14.2, because use pure, older, and very compatible libs, and not need by default things like : systemd, pulseaudio, avahi. this three things on my machines works very wrong and its the worse for me the distros use that 3 things, because make my system very slowpoke.

But builds things under Slackware 14.2 (i had 32 Bits version & 64 Bits version on separate partitions for builds things for that arqutectures more accurate i can) is a just personal preference for had precompile binary executable more compatible with modern distros with more update packages.

AJenbo commented 3 years ago

We now have a Spanish translation so that should be another issue solved for you.

inukaze commented 3 years ago

Thank you very much :D

AJenbo commented 3 years ago

It's only 53% done so if you are able to help finish it that would be apriciated :)

inukaze commented 3 years ago

Fine, i am going try to compile under Slackware(64) 14.2

AJenbo commented 3 years ago

you can just grab the latest test version from the build server https://35994-143324737-gh.circle-artifacts.com/0/devilutionx_linux_x86_64

inukaze commented 3 years ago

Where is the spanish translation for DevilutionX? i wanna edit and complete the translation :D

AJenbo commented 3 years ago

It would be better if you posted in our chat instead of long-closed issues. The translation template is in the Translations, it's called devilutionx.pot. You can use Poedit to do the translation. About 72% of the text is already translated, but it's a bit rough so it's probably best to go over all of it. Most of all the Hellfire portion is untranslated.

inukaze commented 3 years ago

Which chat ? Well sadly the poedit i can't use it

i try to use a precompiled version, fail with libraries wxGTK after i try to compile the deps and poedit, every was compile but when i try to run i just get « Segmentation Fault »

after i try Windows version, downloading from the site, and Wine is not 100% Compatible with the poedit. well i am going to clean the ram from LiveUSB and pass fcsk to see if that can help me with the segmentation fault or simple i just compile older versions of Poedit can use Boost 1.59 and older.

AJenbo commented 3 years ago

The chat that is mentioned at the top of the readme image

You can also use Gtranslator, Lokalize, or just edit it in a text editor. I also saw you posted a screenshot from a Windows 7 machine so you could do it there as well.

You generally seem to have a lot of issues stemming from using Slackware, might also just consider using something newer.

AJenbo commented 3 years ago

There are also browser-based editors: https://localise.biz/free/poeditor

inukaze commented 3 years ago

There are also browser-based editors: https://localise.biz/free/poeditor Thanks for that link, i had translate the mayor part from the text editor " joe "

Well i don't like use discord, i prefer Telegram Channels For Content and (Super)Groups for Chat

i had installed the PoEdit 1.8.12 for Windows XP, this version is working fine with Wine. and well i start the translation using the pot file you had share, basically my spanish translation is from the scratch, i hope finish my first version of this translation tomorrow.

and well after of that i need play the game complete again, to see in where i must arrange the words for looks fine and had coherence.

You generally seem to have a lot of issues stemming from using Slackware, might also just consider using something newer.

With Slackware it has been with the distribution that I have had the least errors

I prefer to do everything from Slackware precisely because I don't need new things, a new version of Slackware comes out approximately every 7 years and the binaries executable are most stable.

i had compile a version under Slackware(64) 14.2 [32 Bits & 64 Bits Binaries Executables, no cross-compile, because when i make a crosscompile of 32 bits native under 64 bits system, and i try execute the 32 bits crosscompile on 32 bits 100% native, never works because don't had idea which is that executable ]

If you like to give it a try (for example in a virtual machine, or Live USB like Lubuntu 16.04), you can download it from here -> https://www.mediafire.com/file/yu7hcgan6v9oq59/DevilutionX-v1.2.1-4B7409A8.7z/file

I recommend using any GNU / Linux distribution from 2016 onwards in case you want to use this version of DevilutionX.

AJenbo commented 3 years ago

Well i don't like use discord, i prefer Telegram Channels For Content and (Super)Groups for Chat

Ok, we don't.

inukaze commented 3 years ago

Well i just had translate around 79%

DevilutionX-Inu-Transpanish

Well i need make test for better arrange text in-game, but i notice the DevilutionX can't show spanish characters like :

¿ á é í ó ú ñ

For example here the « ñ » / " ñ " is missing DevXT1

Here the « ó » and « ú » are missing DevXT3

By the moment looks like if Item name are not translated but well, by now i need finish 100% the first version of translation for start fix it xD. DevXT4

Suggestions If possible, For future versions, add an option for use « voices » : Original, or transtaled if the users make a Fandub for npc voices in their own language. i think should be a directory structure like

lang/text/en lang/text/es lang/voice/en lang/voice/es

or lang/en/voices lang/es/voices

on the up directory of voices, the translation texts files

Dunno, you don't have a special map just for test the translation without combat? i just want access to every dialog (chat with npc, buy/sell) to see in where i must make a fix without play whole game.

AJenbo commented 3 years ago

fonts are being worked on, use the chat instead of commenting on closed issues.

AJenbo commented 3 years ago

The fonts are now in in case you have not noticed 🙂

inukaze commented 3 years ago

Oh when i post the lastest bug i saw with « Resistencia Magica » when you close the issue, i had upgrade and i notice in that moment, but i just need to re-edit all text with every dialog of every npc, because the text now had a diferent aligment, and well i need fix my translation just for that.

AJenbo commented 3 years ago

because the text now had a diferent aligment, and well i need fix my translation just for that

Could you post before an after shots of that?

inukaze commented 3 years ago

because the text now had a diferent aligment, and well i need fix my translation just for that

Could you post before an after shots of that?

Sorry for too late answer, no i can't right now but i am very happy for this -> https://github.com/diasurgical/devilutionX/releases/tag/1.3.0 Finally this version is publish on release section, and with the source code. i am trying compile right now.

i prefer use this stable version for make the corrections on my translation for this engine version.

Compile process, moved to -> https://github.com/diasurgical/devilutionX/issues/516

AJenbo commented 3 years ago

https://github.com/diasurgical/devilutionX/blob/master/docs/building.md#building-from-source

also don't post multiple topics in the same issue