diasurgical / devilutionX

Diablo build for modern operating systems
Other
7.99k stars 781 forks source link

[request]be able to sell from inventory screen #6329

Closed Layarion closed 1 year ago

Layarion commented 1 year ago

I know this request is going to be a bit different from the other features of X, but hear me out.

Sometimes i have to make a trip back just because i'm full, even though i'm still fine on heath and mana. I feel like having to break out of the dungeon only for the reason of, i ran out of room, breaks the dungeon crawler vibe.

especially when it's low quality stuff. "so don't pick up the low quality stuff", well i'm still learning what is, plus i'm a bit of a hoarder.

idk how we'd go about implementing this though. Maybe right-shift clicking an item sells it?

kphoenix137 commented 1 year ago

A GUI based shop is still up in the air. I've been advocating for it. Just have to convince everyone else it's a positive change.

Layarion commented 1 year ago

oh sorry, i tried searching for post like it already. i must have not googled the right word

qndel commented 1 year ago

Definitely mod territory.

qndel commented 1 year ago

A GUI based shop is still up in the air. I've been advocating for it. Just have to convince everyone else it's a positive change.

Think you misunderstood his suggestion, he wanted to be able to sell items without having to leave the dungeon

AJenbo commented 1 year ago

I learned to be less of a hoarder, I think that was the right solution.

Layarion commented 1 year ago

Definitely mod territory.

hey if such a mod were made, would it prevent other mods from being installed? like the ones listed on this repo.

DakkJaniels commented 1 year ago

Every mod is it's own binary, so yes, unless you changed the code to implement whatever it is you wanted in that mod.

kphoenix137 commented 1 year ago

A GUI based shop is still up in the air. I've been advocating for it. Just have to convince everyone else it's a positive change.

Think you misunderstood his suggestion, he wanted to be able to sell items without having to leave the dungeon

Ah okay. Yeah that's definitely never going to happen

AJenbo commented 1 year ago

Definitely mod territory.

hey if such a mod were made, would it prevent other mods from being installed? like the ones listed on this repo.

You can install them all, but you can't necessarily combine them in to one game. Each one is a stand alone game since in Diablo there is no mechanism for loading mods, let alone multiple ones.

julealgon commented 1 year ago

@Layarion I know this is closed (and IMHO for good reason), but how would you even start to justify selling items from the dungeon in a way that fits thematically in the game?

I mean... I know we are talking about a game here and that not everything needs to be realistic, but what exactly would be happening when you click an item in your inventory? Are you teleporting the item to the vendor somehow?

The reason I ask is because there were some games who tried to actually give an ingame explanation for this and created mechanics around it, such as "you have a pet that you ask to go to town sell your items".

Your argument for "breaking the dungeon crawler vibe" is fair and good, but what you are suggesting here, as it is, just completely destroys any sense of in-game continuity/logic/realism, while at the same time removing a decision point (in a game where there are not that many decisions to make...) which is "do I really care about this item enough or not?".

Layarion commented 1 year ago

well the short of it is i wouldn't, also i played a bit of Torchlight myself, though not much (yet). There's a lot in the game that you already just kinda "accept", like that you can't turn a club sideways to fit into your "pack" even though there's room.

as for the choice thing, in the early game it feels like a choice yes...but in the late game it feels like the game wasn't meant to tax your mood with trips back and forth. i get what you're saying, just make the choice to pick up only uncommon items...but after making a lot of trips back and forth through town from griswald and back to the witch, it gets tedious. the atmosphere starts to lose it's charm.

i just feel like this would enhance what i think the game wanted to focus on, which i don't think was on the selling part, but on the getting loot part.