diasurgical / devilutionX

Diablo build for modern operating systems
Other
7.67k stars 751 forks source link

[Issue Report]: Full screen option on Nintendo Switch #7032

Open locksoft opened 3 months ago

locksoft commented 3 months ago

Operating System

Nintendo Switch

DevilutionX version

1.5.2

Describe

I guess the full screen option is meant for desktop versions of the app. On consoles like Nintendo Switch it has no sense, as there's not a desktop. So, enabling it, creates some weird results, depending on the set screen dimension (480p, 720p, 1080p):

SI_1

SI_2

Maybe is it better to remove it in the next releases?

I also noticed other options that seem not useful at all on a console, like the keyboard shortcuts settings (the gamepad one is the only working here).

To Reproduce

Settings > Graphics > Full screen

Expected Behavior

No option at all.

Additional context

No response

DakkJaniels commented 3 months ago

Isn't that how it works on PC? If you turn off full screen, it doesn't upscale the pixels to your screen resolution.

AJenbo commented 3 months ago

Not quite, but sort of.

Anyway it would probably be fine to have a condition to set this to hidden for consoles (same as with quit)

locksoft commented 3 months ago

Anyway it would probably be fine to have a condition to set this to hidden for consoles (same as with quit)

I think it’s possible to quit apps on the Switch, several emulators and utilities have an option for that (not sure if official games do, however). But it’s something like the broken sounds after the console wakes up from the sleep: I’ve no idea about where to report the problems (I can’t sign up in the dev-kit forum, and I’ve no idea who’s working on the Switch porting of this code).

AJenbo commented 3 months ago

But it’s something like the broken sounds after the console wakes up from the sleep

Probably we do not want that.

I’ve no idea about where to report the problem

Is it a problem?

I’ve no idea who’s working on the Switch porting of this code

No one is actively maintaining switch support, which makes it hard to do anything specific for Switch

locksoft commented 3 months ago

But it’s something like the broken sounds after the console wakes up I’ve no idea about where to report the problem Is it a problem?

The quit one not at all. :) The sound yes, it means you can’t turn the Switch off (without restarting the game).

I’ve no idea who’s working on the Switch porting of this code No one is actively maintaining switch support, which makes it hard to do anything specific for Switch

I see. Many thanks for keep working on it then. <3