search

diasurgical / devilutionX

Diablo build for modern operating systems
Other
8.09k stars 794 forks source link

[Issue Report]: No differentiation between keymapper and padmapper in German translation #7187

Open Gunnar-GO opened 4 months ago

Gunnar-GO commented 4 months ago

Operating System

Windows x64

DevilutionX version

1.5.2

Describe

At the xbox port i have under options a dupe entry of control settings, "Tastaturbelegung" at least in the german translation, other i didn't checked before. This should be a minor, since is a dupe, so maybe an duped line etc.

Actually the Translation is not the best since at last half of the ports should use other controls than a keyboard.

To Reproduce

Go to settings.

Expected Behavior

1 entry

Additional context

No response

StephenCWills commented 4 months ago

It's not a duplicate entry, it's an issue with the translation.

https://github.com/diasurgical/devilutionX/blob/7211958a05c04bb3d3e94248462eb96ae281869c/Translations/de.po#L7198-L7212

Keymapper is for mouse-and-keyboard. Padmapper is for gamepad. So there needs to be two entries in the settings. The translation should differentiate between these two setups.

qndel commented 4 months ago

Also a screenshot or a pic would've been super helpful

AJenbo commented 4 months ago

@Gunnar-GO are you able to provide a better translation of the two words?

Gunnar-GO commented 4 months ago

@qndel i'm not sure if it was meant funny, but sure: FullSizeRender

@AJenbo, uhm "Tastenbelegung" and "Controllerbelegung" or if keep an eye at the english one GamePad- / "Padbelegung" would fit to the last one also. Since the port targets doesn't have any keyboard may be it could also be hidden? (this point would fit for 3DS, vita, etc. also )

AJenbo commented 4 months ago

You can actually connect a keyboard to the original Xbox using a USB adapter and it will work with games that supports it. For Vita you can use Bluetooth. The 3DS even has an official keyboard.

Would you be willing to make the corrections to the German translation: https://github.com/diasurgical/devilutionX/blob/master/Translations/de.po Then I can approve an merge it.