search

diasurgical / devilutionX

Diablo build for modern operating systems
Other
8.08k stars 794 forks source link

Fix visually overlapping sprites for wall spells #7208

Closed kphoenix137 closed 2 months ago

kphoenix137 commented 3 months ago

Fixes: https://github.com/diasurgical/devilutionX/issues/7205

Fixes the problem where wall spells create visible missiles that overlap in the center of the wall, resulting in double damage.

qndel commented 3 months ago

why touch all that whitespace stuff?

kphoenix137 commented 3 months ago

why touch all that whitespace stuff?

what?

qndel commented 3 months ago

why touch all that whitespace stuff?

what?

all that stuff that was basically 2 duplicated blocks of code reusing variable names, you changed that to 2 sets of variables, why introduce unnecessary diff? Makes it harder to review ;)

kphoenix137 commented 3 months ago

why touch all that whitespace stuff?

what?

all that stuff that was basically 2 duplicated blocks of code reusing variable names, you changed that to 2 sets of variables, why introduce unnecessary diff? Makes it harder to review ;)

Please provide suggested changed and I'll commit

AJenbo commented 2 months ago

A word or two on what the issue is makes the log a bit more useful :)