search

diasurgical / devilutionX

Diablo build for modern operating systems
Other
8.08k stars 795 forks source link

Change Screenshot Functionality #7431

Open kphoenix137 opened 1 month ago

kphoenix137 commented 1 month ago

Removes:

Adds:

StephenCWills commented 1 month ago

The other downside is that the chat message will linger on screen much longer than the red palette.

EDIT: The other other downside is that it may interfere when taking screenshots of conversations in chat.

EDIT2: And potentially exposing personal info in the screenshot.

AJenbo commented 1 month ago

Cutting it down to just the file name or relative path, or no file name is other options.

We could also use the info box that's also used for shrines and loading rather then the chat, that way it's not affecting the chat.

kphoenix137 commented 1 month ago

Cutting it down to just the file name or relative path, or no file name is other options.

We could also use the info box that's also used for shrines and loading rather then the chat, that way it's not affecting the chat.

Absolutely. I think that DiabloMsg might not be a good idea because it's kind of annoying. I think anything new introduced text based to the user should be chat based rather than DiabloMsg for that reason.

kphoenix137 commented 1 month ago

Removed the file path from the chat message

StephenCWills commented 1 month ago

I think that DiabloMsg might not be a good idea because it's kind of annoying.

Maybe so, but at least it can be dismissed. It does the player no good to keep the screenshot message hanging around in their chat log.

kphoenix137 commented 1 month ago

I think that DiabloMsg might not be a good idea because it's kind of annoying.

Maybe so, but at least it can be dismissed. It does the player no good to keep the screenshot message hanging around in their chat log.

We could add a bool that prevents it from being added to the chat log (the one you get with the hotkey)

FitzRoyX commented 1 month ago

Instead of displaying text, you could play an unused sound effect like vtheft.wav

kphoenix137 commented 1 month ago

Instead of displaying text, you could play an unused sound effect like vtheft.wav

Yeah we could do that.

kphoenix137 commented 1 month ago

Updated

StephenCWills commented 1 month ago

Since we decided to remove the on-screen message, I was kind of hoping maybe we could use a camera shutter sound effect to make it more obvious. Here is one I found that sounds pretty good to me. It might work with a bit of editing. Released under the cc0 license so it's public domain.

https://freesound.org/people/mrrap4food/sounds/619062/