search

diasurgical / devilutionX

Diablo build for modern operating systems
Other
8.11k stars 796 forks source link

[Issue Report]: Blood Claw Unique Pack Wakeup Issue #7448

Closed NiteKat closed 3 weeks ago

NiteKat commented 1 month ago

Operating System

Windows x64

DevilutionX version

1.5.3

Describe

The Blood Claw Unique and his minions wake up separately instead of all waking up if any one individual is woken up.

To Reproduce

  1. Find the Blood Claw Unique Pack
  2. Walk near them at an angle that gets you close to just 1 or a small number of them.
  3. Observe those few wake up, but not the whole pack.

Expected Behavior

When any one of the Blood Claw unique pack wakes up, they all should.

Additional context

No response

StephenCWills commented 1 month ago

The GroupUnity() function used to have a loop that wakes up the whole pack when processing the leader.

https://github.com/diasurgical/devilution/blob/bbda8dd586c65b03028ec75c52f8ea8627eb9ff5/Source/monster.cpp#L3524-L3529

The logic to wake them up was removed in #2379, and the loop was subsequently removed in #2421. I suppose it will need to be added back in some form.

StephenCWills commented 1 month ago

Here's a save with Goldblight for testing. single_0.sv.zip

Recommended debug commands:

dev.player.god()
dev.search.monster("Goldblight")