search

diasurgical / scalpel

The argent tools beneath our sickening operation
The Unlicense
16 stars 5 forks source link

sync table of ownage with Devilution master #12

Open mewmew opened 4 years ago

mewmew commented 4 years ago

I wrote a little tool to diff the function name usage in Devilution vs. those defined in the table of ownage.

Most names are correct, but there are ~80 or so that needs to be update in surgery/function.md so they have the same name as that used in Devilution.

Note, a few of these may be false positives (e.g. CopyInt) as I ran the tool on DevilutionX/Source and those functions were introduced in DevilutionX for save file handling.

A set of function names related to rendering were recently updated as part of the cleanup in diasurgical/devilution#1802, so they should be easy to sync.

Oh, and I just realized, that a few functions are added to Devilution from the debug release of Diablo, so those will show up in the list as I only checked the v1.09b addresses of the surgery/functions.md table.

The list is as follows:

P.S. if someone is curious, I can share the horrid tool that was used to produce this list :p I'm learning how to parse C++ as I go :)

(cc: @AJenbo as you are currently not listed as a watcher for updates to this repo ^^)

AJenbo commented 4 years ago

Parsing thease files might be very helpful :) https://github.com/diasurgical/devilution/tree/hellfire/comparer-config

P.s. Fine ill add one more project to my watch list

mewmew commented 4 years ago

Parsing thease files might be very helpful :) https://github.com/diasurgical/devilution/tree/hellfire/comparer-config

I ran a diff against comparer-config/diablo.toml, which had a diff of ~40 functions:

AJenbo commented 4 years ago

RenderTile and RenderLine are DevilutionX only as well, they replace drawUpperScreen and drawLowerScreen