search

diazona / setuptools-pyproject-migration

Generate a pyproject.toml file from setuptools
https://setuptools-pyproject-migration.readthedocs.io/en/latest/
MIT License
16 stars 3 forks source link

Work around incompatibility between Python 3.12 and setuptools<66.1 #140

Closed diazona closed 10 months ago

diazona commented 11 months ago

Older versions of setuptools fail to import distutils on Python 3.12, presumably due to the removal of distutils from the standard library. This bug was fixed in https://github.com/pypa/setuptools/pull/3685, and setuptools 66.1 was the first version released that includes the fix. (I'm not sure exactly how that PR fixed the bug, but it doesn't matter.)

Because setuptools 66.0 understandably does not declare itself to be incompatible with Python 3.12, I'm bumping our minimum setuptools version requirement on that Python version to reflect the incompatibility, and adjusting the CI configuration to match.

Closes #139

diazona commented 11 months ago

I rebased #137 on top of this and checked that its tests pass. :+1:

diazona commented 10 months ago

Heh, indeed... But it happens, and in this case it's really a good change overall IMO, so no complaints.