search

dib-lab / dammit

just annotate it, dammit!
http://dib-lab.github.io/dammit/
Other
88 stars 28 forks source link

get mkdocs theme via gh-actions #176

Closed bluegenes closed 4 years ago

bluegenes commented 4 years ago

Ready for review @camillescott!

I couldn't get our dib-lab submodule to install properly (see https://github.com/dib-lab/mkdocs-material-dib/pull/13).

For now, I used the materials theme instead and modified our mkdocs.yml to work with the updated theme. Looks nearly identical (see http://dib-lab.github.io/dammit) - @charlesreid1 what are we missing out on by going to the default materials theme?

this was helpful for updating mkdocs.yml: https://squidfunk.github.io/mkdocs-material/releases/5/#changes-to-mkdocsyml

Merging this will remove mkdocs-material-dib and corresponding vulnerabilities.

camillescott commented 4 years ago

Awesome! Not so much to review here -- I'm all for removing the pile of vendored theme crap and making use of actions. Smashing that merge button.