dib-lab / khmer-protocols

Other
19 stars 24 forks source link

upgrade spades for nicer error messages #123

Closed SherineAwad closed 9 years ago

SherineAwad commented 10 years ago
SherineAwad commented 10 years ago

@ctb: Please don't merge. Work in progress

SherineAwad commented 10 years ago

@ctb idba assembler sometimes doesn't generate scaffolds (happens with Podar set without inflation), so I have to update calc-best-assembly command to capture contig.fa instead of scaffold.fa. Should I update it in the protocol just in case no scaffolds are generated?

ctb commented 10 years ago

Let's put this on the list of things to talk about. Can you add this as a separate issue in khmer-protocols? Also, does it crash, or what? What happens? Is this a memory problem?

SherineAwad commented 10 years ago

@ctb ..ping. Or ping discussion about it. Either to remove scaffolds and replace it by contig.fa?

ctb commented 10 years ago

On Sun, Jul 20, 2014 at 03:06:36PM -0700, Sherine Mahmoud wrote:

@ctb ..ping. Or ping discussion about it. Either to remove scaffolds and replace it by contig.fa?

scaffols are probably better if they exist. But I think what we really need to do is alert people when assemblers fail...

C. Titus Brown, ctb@msu.edu

SherineAwad commented 10 years ago

@ctb Please take a look and I am fine with merge.

qingpeng commented 10 years ago

Is there any explanation about the failure to generate scaffolds in idba documentation? If it is normal that no scaffolds are generated by idba sometimes, I think it is reasonable to at least make a note about this.

On Jul 21, 2014, at 6:06 AM, Sherine Mahmoud notifications@github.com wrote:

@ctb ..ping. Or ping discussion about it. Either to remove scaffolds and replace it by contig.fa?

— Reply to this email directly or view it on GitHub.

ctb commented 9 years ago

Merged!