dib-lab / khmer

In-memory nucleotide sequence k-mer counting, filtering, graph traversal and more
http://khmer.readthedocs.io/
Other
748 stars 294 forks source link

Wrong python interpreter in OSX version #1152

Open bmpvieira opened 9 years ago

bmpvieira commented 9 years ago

All *.py files have #!/Users/mcrusoe/build/bin/python

Steps to reproduce

brew install python
pip install virtualenv
virtualenv khmer
. khmer/bin/activate
pip install khmer
cat khmer/bin/*.py | grep mcrusoe
ctb commented 9 years ago

On Mon, Jul 06, 2015 at 06:52:49AM -0700, Bruno Vieira wrote:

All *.py files have #!/Users/mcrusoe/build/bin/python

Steps to reproduce

brew install python
pip install virtualenv
virtualenv khmer
. khmer/bin/activate
pip install khmer
cat khmer/bin/*.py | grep mcrusoe

Hi Bruno, thanks for the note - this is definitely not true of the scripts in the git repo, so somewhere along the way the shebang must be getting updated inappropriately. Could you paste in the output from what you're running, if you get a chance?

@mr-c any thoughts?

--titus

C. Titus Brown, ctbrown@ucdavis.edu

mr-c commented 9 years ago

Wacky, they are indeed that way in the OS X wheel at https://pypi.python.org/packages/2.7/k/khmer/khmer-1.4.1-cp27-none-macosx_10_10_intel.whl#md5=70d6d4f31fcbb5292fd27ce5819ed4f8

I don't have access to an OS X machine right now to investigate, unless @camillescott can figure out why I can't ssh to our development imac.

mr-c commented 9 years ago

Thank you @bmpvieira for your report. Using a newer version of setuptools and pip fixed the problem. The upcoming 2.0 release of khmer will not have this issue.

mr-c commented 9 years ago

That is to say, when I create the wheel using a newer version of setuptools and pip the wheel did not embed the local path. 'Twas not your error!

mr-c commented 9 years ago

- [ ] make wheel Py2/Py3 universal via setup.cfg

[bdist_wheel]
universal = 1
mr-c commented 9 years ago

Fweh, made the mistake of repeating this problem. Turns out that PyPI won't let you re-upload a previously deleted file with the same name.

Luckily I was able to switch to the python.org Python v 2.7.10 which names the wheel with the infix 'macosx_10_6' instead of 'macosx_10_10`.

(re: my prior comment about universal wheels, that only works for pure Python packages)

mr-c commented 9 years ago

@bmpvieira This should be fixed for khmer 2.0, I checked all three wheels by hand

bmpvieira commented 9 years ago

Thanks @mr-c, I can confirm that this is fixed.