Bundled bzip2 hardcodes `CC=gcc`

dib-lab / khmer

In-memory nucleotide sequence k-mer counting, filtering, graph traversal and more

http://khmer.readthedocs.io/

Other

757 stars 295 forks source link

Open betatim opened 8 years ago

betatim commented 8 years ago

While investigating a issue with getting khmer to use a different compiler I noticed that one of the third-party bits of code hardcodes CC:

bash -c cd third-party/bzip2 && make -f Makefile-libbz2_so all
gcc -fpic -fPIC -Wall -Winline -O2 -g -D_FILE_OFFSET_BITS=64 -c blocksort.c
...

is there a reason for this or just a bug?

standage commented 8 years ago

No idea!

betatim commented 8 years ago

Ok, if no one remembers a reason, let's declare it a bug 🐛

standage commented 8 years ago

This would be an issue with the upstream though, wouldn't it? It looks like the stock Makefile distributed with bzip2.

Not that we can't modify the code, but there are different considerations re: modifying our code vs bundled third-party code.

ctb commented 8 years ago

Is this causing any problems for anyone? If not, let's drop it until it does.