Closed ctb closed 6 years ago
(Interesting to note that we apparently don't test large Nodegraph size creation anywhere :)
We do test large Nodegraph size, but only if running with the huge
mark (see https://github.com/dib-lab/khmer/blob/ceaebd37c22d6528dd6ae0f13142633dfb5582c3/tests/test_nodegraph.py#L57 and https://github.com/dib-lab/khmer/blob/ceaebd37c22d6528dd6ae0f13142633dfb5582c3/Makefile#L82 ). Should we make another test with something more reasonable instead of 1e13 ?
And int
size depends on the arch, but in x86_64 it is 32 bits. We should use a uint64_t
just to be safe.
I'm trying to create a Nodegraph with starting size 8000000000, and getting the following error:
which seems strange on multiple levels, but there we are.
Same error occurs with:
Isn't
int
64-bit??Here are the lines at issue:
https://github.com/dib-lab/khmer/blob/ceaebd37c22d6528dd6ae0f13142633dfb5582c3/khmer/_oxli/graphs.pyx#L857-L860