search

dib-lab / khmer

In-memory nucleotide sequence k-mer counting, filtering, graph traversal and more
http://khmer.readthedocs.io/
Other
754 stars 296 forks source link

Refactor C++ Test Drivers #18

Open emcd opened 11 years ago

emcd commented 11 years ago

The C++ test drivers consist of a lot of copy pasta, which violates the DRY principle. These should be cleaned up and have common functionality factored out to improve future maintainability and extensibility.

mr-c commented 9 years ago

These are unused and have been so for a while. Perhaps they should be deleted?

kdm9 commented 9 years ago

perhaps ping #788 ?

I'd love to have ./lib as a self-contained and installable library, as we're using it as such. Obviously sans the semver promises that apply to the python api. Removing crud would help :)

camillescott commented 9 years ago

I was actually pondering a C++ test suite the other day -- a lot of my multithreading stuff is low level, and very difficult to test from Python without writing more CPython objects, which kind of defeats the purpose of simple tests by adding tons of extra glue code just to run them in the first place. Unfortunately, I have zero knowledge or experience with C++ testing libs. Thoughts @ctb, @mr-c @luizirber ?

ctb commented 9 years ago

On Thu, Mar 19, 2015 at 08:56:38AM -0700, Camille Scott wrote:

I was actually pondering a C++ test suite the other day -- a lot of my multithreading stuff is low level, and very difficult to test from Python without writing more CPython objects, which kind of defeats the purpose of simple tests by adding tons of extra glue code just to run them in the first place. Unfortunately, I have zero knowledge or experience with C++ testing libs. Thoughts @ctb, @mr-c @luizirber ?

I hear Boost has a testing lib.

camillescott commented 9 years ago

growls

kdm9 commented 9 years ago

This looks pretty cool: https://github.com/philsquared/Catch

Header only, boost licensed.