Open ctb opened 7 months ago
This PR switches slainte over to using calc-full-gather.py from https://github.com/ctb/2024-calc-full-gather / https://github.com/sourmash-bio/sourmash_plugin_branchwater/issues/187, which does not run a whole new gather with a picklist, but instead calculates the columns starting from the fastgather output.
calc-full-gather.py
gather
This has the advantage of being lower memory and faster, per https://github.com/sourmash-bio/sourmash/issues/2950. This is especially true for large nasty rumen samples, ugh.
Before this gets merged, we would need to fix calc-full-gather to work with multiple databases, among perhaps other things.
calc-full-gather
This PR also triggered https://github.com/sourmash-bio/sourmash/pull/2952 :)
This PR switches slainte over to using
calc-full-gather.py
from https://github.com/ctb/2024-calc-full-gather / https://github.com/sourmash-bio/sourmash_plugin_branchwater/issues/187, which does not run a whole newgather
with a picklist, but instead calculates the columns starting from the fastgather output.This has the advantage of being lower memory and faster, per https://github.com/sourmash-bio/sourmash/issues/2950. This is especially true for large nasty rumen samples, ugh.
Before this gets merged, we would need to fix
calc-full-gather
to work with multiple databases, among perhaps other things.