search

dib0 / NHapiTools

The NHapiTools are tools that will make using NHapi (the open source .Net HL7 implementation) easier. NHapi has a steep learning curve and not everything works as easy as it should. NHapiTools aims to improve that without tampering with NHapi itselves.
MIT License
85 stars 59 forks source link

Modify package references for target framework .net standard 2.0 #17

Closed tomatostudio closed 3 years ago

tomatostudio commented 3 years ago

Hi folks,

I just would like to use the tool in my .NET standard project. I found the package on nuget didn't work. Maybe the reference packages were not suitable. I made some modifications on that. Please feel free to check and correct them.

Best regards, JJ

milkshakeuk commented 3 years ago

@dib0 I Don't think some of the changes of this PR should have been merged for example reference to nhapi.core which is a NuGet package created from an old fork of nHapi, and has not been updated since 03/07/2019.

nHapi has been progressing with its v3 preview releases which do officially support netstandard2.0, there should be a v3 final release out in the next couple of weeks.

also, the global.json has been lowered which ideally, we shouldn't do, just because of security patches Microsoft provide

I will look to create a PR after it has been released.

milkshakeuk commented 3 years ago

@dib0 nHapi v3 has now been released and #21 is the PR I promised.