search

dib0 / NHapiTools

The NHapiTools are tools that will make using NHapi (the open source .Net HL7 implementation) easier. NHapi has a steep learning curve and not everything works as easy as it should. NHapiTools aims to improve that without tampering with NHapi itselves.
MIT License
85 stars 59 forks source link

Incorrect message structure for Acks generated with MakeACK #18

Closed MightyJudge closed 3 years ago

MightyJudge commented 3 years ago

There appears to be an issue in the MakeACK method causing it to create invalid Acks when the message structure (MSH-9-3) field is populated in the incoming message.

As the MSH segment is copied from the inbound message to the ACK and MSH-9-3 is not updated Acks generated from an incoming message that had MSH-9-3 populated will also have MSH-9-3 populated. As Ack’s always have a differing structure to the inbound message this in not valid.

dib0 commented 3 years ago

I solved it by clearing the MSH-9-3 field. It will be included in the next release.