search

diba-io / bitmask-core

Core functionality for the BitMask wallet
https://bitmask.app
Other
95 stars 21 forks source link

WIP/Docker test volumes #307

Open rustchain64 opened 1 year ago

rustchain64 commented 1 year ago

Testing the run command against the Dockerfile with:

docker run -d --restart always -p 7060:7070 -v /Applications/bitmask/bitmask-core/target/release:/app -v /var/lib/docker/volumes/my_data_volume:/_data --name bitmaskd-st160 -t bitmaskd-st160-image:Rc.17 -e “CARBONADO_DIR=/data”

the volume mounts allow for updating source code, at the same time, writing to the volume data mount

rustchain64 commented 1 year ago

Final docker RUN command THIS WRITES TO /mnt/storage/carbonado-docker docker run -it --user root --restart always -p 7060:7070 --mount type=bind,source=/mnt/storage/carbonado-docker,target=/tmp/bitmaskd/carbonado --name bitmaskd-st160 -t bitmaskd-st160-image:Rc.0.6.2 -e “CARBONADO_DIR=/data” bash

cryptoquick commented 1 year ago

Alright, that technically gets the job done, but it's inelegant. Can you make it check runtime env vars to set CARBONADO_DIR to /data/bitmaskd/carbonado/ ? Heck, I think that's fine to set even at compile time.

crisdut commented 1 year ago

I intent make a review that today, ok?

cryptoquick commented 1 year ago

Sounds good

rustchain64 commented 1 year ago

Had to move ENV to runtime in order for rust to pick it up in Carbonado-Core

Runtime

FROM rust:1.69-slim-buster AS runtime

ENV CARBONADO_DIR=/data/bitmaskd/carbonado/

rustchain64 commented 1 year ago

Hunter, I will double check but I believe in regards to docker we where at 1.71 Rust , but had issues, that caused us to degrade back to 1.69.. I can pull the latest and rebuild and test. I was focused on the AWS infrastructure until now, But can double back on Bitmask Core, tomorrow. I will be working on Saturday. Wesley

On Fri, Aug 18, 2023 at 6:58 AM Hunter Beast @.***> wrote:

@.**** requested changes on this pull request.

Can we see if CI passes if this is updated against the latest development branch?

Also, I'd like to upgrade to the latest stable version of Rust, 1.71.1.

— Reply to this email directly, view it on GitHub https://github.com/diba-io/bitmask-core/pull/307#pullrequestreview-1584524466, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATWG7QTWLHS6UZ42ZCCJNJDXV5RF5ANCNFSM6AAAAAA24YLK5Y . You are receiving this because you authored the thread.Message ID: @.***>