diba-io / bitmask-core

Core functionality for the BitMask wallet
https://bitmask.app
Other
95 stars 21 forks source link

Use RGBA Base85 encoding for RGB strings #320

Closed cryptoquick closed 1 year ago

cryptoquick commented 1 year ago

For long RGB strings returned by RGB methods such as consignments, contracts, and genesis, we should instead use ASCII-armored base85 encoding, as per Maxim's recommendation, like so: https://github.com/RGB-WG/rgb-schemata/blob/master/schemata/CollectibleFungibleAssets-RGB25.rgba

crisdut commented 1 year ago

I think we use that in majority operations, but I intent write some tests to cover the format in import and transfer operations, ok?

If works, I will close this PR.

cryptoquick commented 1 year ago

It seems to work, we just didn't have the armored property in one of the TypeScript interfaces. Thanks!