search

diba-io / bitmask-core

Core functionality for the BitMask wallet
https://bitmask.app
Other
95 stars 21 forks source link

Verify chain / network on RGB invoice #362

Open cryptoquick opened 1 year ago

cryptoquick commented 1 year ago

Different from #360; We need to verify if an invoice for the wrong network has been provided, and return an error if that is the case. We'll also need tests, and the necessary upstream functionality.

crisdut commented 1 year ago

Hi @cryptoquick and @josediegorobles , we can make solve it, if add optional parameter in invoice called network. This maintain compatibility with other wallets and prevents the problem use invoices in wrong network. Does make sense?

cryptoquick commented 1 year ago

This should already be on the RGB invoice struct

crisdut commented 1 year ago

This should already be on the RGB invoice struct

Yes, but it is only used in case you know the beneficiary (see here).

cryptoquick commented 1 year ago

So, that would be an invoice that includes a blinded UTXO? That's fine I think.

crisdut commented 1 year ago

So, that would be an invoice that includes a blinded UTXO? That's fine I think.

No, RgbInvoice parse the chain only when beneficiary is a bitcoin address, not when a blind UTXO

cryptoquick commented 1 year ago

I see. You're right, we may need to add an optional parameter to the invoice then. I'll also tag @dr-orlovsky and @fedsten on this issue so they're aware of the issue.