search

diba-io / bitmask-core

Core functionality for the BitMask wallet
https://bitmask.app
Other
95 stars 21 forks source link

fix: taproot derived xpub #449

Closed jasonribble closed 9 months ago

jasonribble commented 9 months ago

The example seed phrase was providing the the main extended public key. i.e derivation path m This can be confirmed on bip32.net

Here's the m derivation in the current version:

image

image

We needed to provide an xpub that included the taproot descriptor. Since we already had the function watcher_xpub, that's all that needed to be switch out.

Now, if a user wants to copy the xpub for a watch only wallet; they will see

With the additional test, we can see that we now have the proper watch-only address.

jasonribble commented 9 months ago

What do we do with the failing Rust/test-wasm?

crisdut commented 9 months ago

What do we do with the failing Rust/test-wasm?

Apparently, the problem is related to the ehadless execution timeout, as all tests passed.

cryptoquick commented 9 months ago

It always depends on why the test fails. If it's just an issue with CI, we're not too worried about it.

jasonribble commented 9 months ago

How exciting! Thank you.