search

dibyendumajumdar / Suravi

Suravi is a small distribution of Ravi/Lua 5.3 with batteries such as cjson, lpeglabel, luasocket, penlight, torch7, luv, luaossl
65 stars 3 forks source link

Suggested library: busted #1

Open italomaia opened 6 years ago

italomaia commented 6 years ago

Testing library for lua: https://olivinelabs.com/busted/

dibyendumajumdar commented 6 years ago

thank you - will review. agree that best to have a standard unit test library included

dibyendumajumdar commented 6 years ago

btw Torch comes with a test framework too. See https://github.com/dibyendumajumdar/ravi-torch7/blob/master/doc/tester.md

italomaia commented 6 years ago

Well, torch do seem to overlap with a lot of internal tools. Probably not the time to wonder if that is a good thing, but, wasn't there a warning that torch is being "replaced" by pyTorch? Should this distro rely so much in a soon-to-be defunct project? Not questioning torch greatness, of course. Just ... wondering.

dibyendumajumdar commented 6 years ago

Yes Torch is sadly now under maintenance. But that is okay as I expect to maintain and support my fork of Torch long term. Re the tools that overlap - that in itself is not an issue - I guess I have to review carefully whether the tool is used by enough projects. To be honest it may be that none of the libraries I am including use Busted (I haven't checked).

italomaia commented 6 years ago

If you plan to keep your torch fork, long-term, maybe, shifting from non-core "under maintenance" libraries would be the way to go. In the long-run that would be less code to maintain. Just a thought.

italomaia commented 6 years ago

Regarding busted usage, I've found that the libraries listed in the readme do not use busted.

Some fellow suggested busted usage for luasocket (and that's about it): https://github.com/diegonehab/luasocket/issues/227

dibyendumajumdar commented 6 years ago

Although it would be nice to migrate stuff in torch it is less of an issue, I guess easier option is to add the most commonly used unit testing framework