dicarlolab / genthor

Generative models and Bayesian techniques with thor
5 stars 12 forks source link

fixed image texture bug #12

Closed pbattaglia closed 11 years ago

pbattaglia commented 11 years ago

I fixed the .mtl issue so that the textures load properly.

Here's how you can test everything:

pbattaglia commented 11 years ago

So you want to have scikit-data define the project root? Why? Shouldn't the project root be defined as a OS env variable, and then the project manages its own internal structure? That is the idea behind my edits to genthor/ init.py -- why don't we just make scikits-data aware of genthor.GENTHOR_PATH ? Maybe I'm confused.

yamins81 commented 11 years ago

Well, so I think that the genthor project stuff has two parts:

a) the tools for rendering and the structure for data when its "inside" a genthor cache directory --

b) the stuff for managing a "specific instantiation" of a rendered image dataset

I think that the stuff for b) should set the absolute path for the containing directory where stuff will be stored. The stuff for a) should just set relative paths for stuff internal to that directory.

E.g. code in genthor.init.py should not, imo, set absolute paths. it might want to define the relative paths for those needed resource folders, etc. But the absolute path management (and the ability to have multiple instantiations of datasets with files in flexible different locations) should be handled by scikit-data.