JWT token handling is now possible

dice-cyfronet / atmosphere

Atmosphere cloud platform

MIT License

7 stars 3 forks source link

JWT token handling is now possible #291

Closed dharezlak closed 7 years ago

dharezlak commented 8 years ago

JWT token should be passed via the jwtToken property. Also, cloudFacadeUrl, username and roles properties should be passed as usual. Do not pass the csrf* properties as they will take precedence. Accept this merge request if all works well.

nowakowski commented 7 years ago

I need this merged (eventually) but there are failed checks and the PR is not flagged as ready for review. @dharezlak - could you comment on the security warnings? @mkasztelnik - what's our policy on merging branches which are not cleared by Hakiri?

dharezlak commented 7 years ago

If relevant, I propose to create a separate issue for the security warnings which refer to server-side vulnerabilities. This PR consisted of only client-side (aka JS) code modifications.

mkasztelnik commented 7 years ago

I agree with @dharezlak