search

dice-group / AGDISTIS

AGDISTIS - Agnostic Named Entity Disambiguation
http://aksw.org/Projects/AGDISTIS.html
GNU Affero General Public License v3.0
140 stars 37 forks source link

Run without context index #49

Closed RicardoUsbeck closed 6 years ago

RicardoUsbeck commented 6 years ago

Make the master run also without context index.

DiegoMoussallem commented 6 years ago

Just to set context=false in agdistis.properties file. Could you close it?

RicardoUsbeck commented 6 years ago

Need to test it first, consider it staging and leave it open

DiegoMoussallem commented 6 years ago

@RicardoUsbeck Ah OK. In case you want to have a look. I have done a test in https://github.com/dice-group/AGDISTIS/blob/master/src/test/java/AGDISTISTest.java#L83 If you disable context i.e., context=false the test will fail which means that works without context, but if you enable i.e., context=true it will pass.

RicardoUsbeck commented 6 years ago

That is not so nice. That means without contect index, a mvn clean package fails. Let's write it as a new unit test which pays attention to the fact that if works with and without context index.

RicardoUsbeck commented 6 years ago

Closed by fccc311c408571e2b60b639b3ecd7ed5b0dc558e