Clarify index2 naming in config

dice-group / AGDISTIS

AGDISTIS - Agnostic Named Entity Disambiguation

http://aksw.org/Projects/AGDISTIS.html

GNU Affero General Public License v3.0

141 stars 37 forks source link

Clarify index2 naming in config #56

Closed yamalight closed 6 years ago

yamalight commented 7 years ago

Currently in config we have two following fields:

index=index
index2=index_bycontext

From name it is not clear what is index2 and how it's used. I'd suggest doing the following:

[x] (short term) add comment to config file clarifying what it does
[x] (long term) rename it to reflect its role

DiegoMoussallem commented 6 years ago

improved with the new commit.

yamalight commented 6 years ago

@DiegoMoussallem looks like this broke tests: https://gitlab.com/aksw/AGDISTIS/-/jobs/53308720 please fix them

DiegoMoussallem commented 6 years ago

I thought the problem was the one pointed by Ricardo above then I fixed it which was from indextest to index again in property files. But the error still appears. Do you have any tip @yamalight ? because If you download the code e run by maven it works and delivers the same results expected by test-docker.sh.

DiegoMoussallem commented 6 years ago

Seems that https://gitlab.com/aksw/AGDISTIS/commits/master takes time to mirror the commits. lets see

DiegoMoussallem commented 6 years ago

everything is ok now

yamalight commented 6 years ago

looks good, thanks! 👍