search

dice-group / FOX

Federated Knowledge Extraction Framework
GNU Affero General Public License v3.0
188 stars 52 forks source link

Docker image for "en" fails to build #35

Closed yamalight closed 7 years ago

yamalight commented 7 years ago

Current Dockerfile for "en" is broken due to following problems:

Problem 1:

You try to copy fox.properties-dist from outside docker, when it should be copied on inside. This is a simple fix (unless you want to do something else):

- COPY ./fox.properties-dist ./fox.properties
+ RUN cp ./fox.properties-dist ./fox.properties

Problem 2:

You try to copy file that doesn't exists neither outside, nor inside. Where should it come from? My search showed that file with that name already exists in /data/fox/ml/en/ - is that line even needed?

COPY weka.classifiers.functions.MultilayerPerceptron ./data/fox/ml/en/
renespeck commented 7 years ago

The line is a relic of an older version and not needed.

yamalight commented 7 years ago

Awesome, thanks! Multilingual build works fine btw: https://hub.docker.com/r/dicegroup/fox/builds/