dice-group / IGUANA

IGUANA is a benchmark execution framework for RDF triple stores and quad stores
http://iguana-benchmark.eu
Apache License 2.0
25 stars 15 forks source link

Corrected OWL ontology and JSON config schemas #158

Closed AndreaWesterinen closed 2 years ago

AndreaWesterinen commented 2 years ago

Corrected OWL ontology where multiple domains were referenced in a property definition - these should reference a UNION of the classes, else the meaning is that an instance must be BOTH classes (for ex, both a Worker and a Task, which are disjoint); Corrected references to a 'double' datatype which is not valid for OWL (should be xsd:decimal); Removed extraneous 'allOf' declaration in iguana-schema.json; Corrected indentation in the .owl and .json files for improved readability

AndreaWesterinen commented 2 years ago

As regards the questions above:

  1. Patches for calling command line tools on MacOS - Do you have a x86-64 or a ARM mac? What is your OS version? Do you have installed tools via e.g. brew?

I have a x86-64 Mac, macOS Monterey 12.4 (21F79), with some tools installed via brew.

  1. Add several new metrics. This includes changes to the Ontology and to the code to calculate metric values.

I felt it inappropriate to add the new metrics using your namespace, but am happy to do that.

  1. Change datatype of existing metrics from xsd:double to xsd:decimal ... I would disagree with you that it is not a valid type for a DataProperty to use in an OWL ontology.

Please see https://www.w3.org/TR/owl2-syntax/#Real_Numbers.2C_Decimal_Numbers.2C_and_Integers. Double is not a supported datatype.

  1. I am a bit skeptical of the test suite.

I am not sure what your concern is, so I cannot respond.

  1. Removing allOf from iguana-schema.json

I only removed the one, extraneous allOf from the CLIWorker "then" clause.

Please see other comments above, and the link to the documentation of the changes.

AndreaWesterinen commented 2 years ago

Happy to close this request and make the smaller, more consequential ones.