Fix for #191 - Githubissues

dice-group / IGUANA

IGUANA is a benchmark execution framework for RDF triple stores and quad stores

http://iguana-benchmark.eu

GNU Affero General Public License v3.0

24 stars 15 forks source link

Fix for #191 #197

Closed nck-mlcnv closed 1 year ago

nck-mlcnv commented 1 year ago

This pull request also does the following:

Fix the same issue with the countLines method, although it's a quite simple fix for that method.
- For this I've added the getLineEnding method, which returns the used line separator of a file.
Add better tests.

bigerl commented 1 year ago

please resolve conflicts

bigerl commented 1 year ago

Please request an review from @Clueliss when ready.

nck-mlcnv commented 1 year ago

Conflicts have to be resolved and the documentation now needs checked and maybe updated now, because the behaviour of the FileSeparatorQuerySource has been changed.

[x] update documentation
[x] resolve conflicts

nck-mlcnv commented 1 year ago

So apperently, when the files are uploaded to GitHub they may have different line endings than the original ones. That's why I had to add the behaviour, that the expected values for tests are constructed with the proper line endings.