dice-group / ida-pg

GNU Affero General Public License v3.0
6 stars 4 forks source link

Old messages iteration for IDA chatbox #102

Closed maqboolkhan closed 5 years ago

maqboolkhan commented 5 years ago

This functionality will enable IDA's user to cycle through previous messages just like Terminal. Note Remember, its just in Browser memory so it will go away with Page refresh. We can later think about it to store in DB

codecov-io commented 5 years ago

Codecov Report

Merging #102 into master will increase coverage by 16.49%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #102       +/-   ##
=============================================
+ Coverage      7.34%   23.84%   +16.49%     
- Complexity       43       99       +56     
=============================================
  Files            48       48               
  Lines          1279     1279               
  Branches        146      146               
=============================================
+ Hits             94      305      +211     
+ Misses         1185      962      -223     
- Partials          0       12       +12
Impacted Files Coverage Δ Complexity Δ
...c/main/java/upb/ida/bean/cluster/ClusterParam.java 34.78% <0%> (+8.69%) 3% <0%> (+2%) :arrow_up:
...ain/java/upb/ida/bean/cluster/ClusterAlgoDesc.java 41.66% <0%> (+12.5%) 4% <0%> (+3%) :arrow_up:
...da-ws/src/main/java/upb/ida/temp/ExampleMacro.java 16.66% <0%> (+16.66%) 1% <0%> (+1%) :arrow_up:
ida-ws/src/main/java/upb/ida/util/FileUtil.java 42.59% <0%> (+22.22%) 6% <0%> (+3%) :arrow_up:
...n/java/upb/ida/bean/cluster/ParamEntryChecker.java 44.44% <0%> (+44.44%) 3% <0%> (+3%) :arrow_up:
ida-ws/src/main/java/upb/ida/fdg/FDG_Node.java 46.15% <0%> (+46.15%) 5% <0%> (+5%) :arrow_up:
...c/main/java/upb/ida/util/GetCorrectParamTypes.java 50% <0%> (+46.87%) 6% <0%> (+5%) :arrow_up:
.../main/java/upb/ida/rest/MessageRestController.java 52.94% <0%> (+47.05%) 2% <0%> (+1%) :arrow_up:
ida-ws/src/main/java/upb/ida/fdg/FDG_Triple.java 52.38% <0%> (+52.38%) 6% <0%> (+6%) :arrow_up:
...-ws/src/main/java/upb/ida/provider/FdgHandler.java 62.5% <0%> (+56.25%) 2% <0%> (+1%) :arrow_up:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d94bd8...3c6b404. Read the comment docs.

nikit-srivastava commented 5 years ago

@faisal07m could you please confirm the changes by doing a sanity check?

maqboolkhan commented 5 years ago

Pinging @nikit91 @faisal07m

maqboolkhan commented 5 years ago

I am unable to understand travis-ci problem cc @nikit91 @bhatmanjokes