search

dice-group / ida-pg

GNU Affero General Public License v3.0
6 stars 4 forks source link

New visuals implementation: VENN DIAGRAM #105

Closed maqboolkhan closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #105 into master will decrease coverage by 0.38%. The diff coverage is 6.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #105      +/-   ##
============================================
- Coverage     23.84%   23.45%   -0.39%     
- Complexity       99      101       +2     
============================================
  Files            48       50       +2     
  Lines          1279     1313      +34     
  Branches        146      150       +4     
============================================
+ Hits            305      308       +3     
- Misses          962      993      +31     
  Partials         12       12
Impacted Files Coverage Δ Complexity Δ
...s/src/main/java/upb/ida/venndiagram/VENN_ITEM.java 0% <ø> (ø) 0 <0> (?)
...ain/java/upb/ida/venndiagram/VENN_DATA_FILTER.java 0% <0%> (ø) 0 <0> (?)
ida-ws/src/main/java/upb/ida/util/FileUtil.java 33.82% <0%> (-8.77%) 6 <0> (ø)
.../java/upb/ida/venndiagram/VENN_DATA_GENERATOR.java 0% <0%> (ø) 0 <0> (?)
.../java/upb/ida/provider/RiveScriptBeanProvider.java 100% <100%> (ø) 2 <0> (ø) :arrow_down:
...s/src/main/java/upb/ida/venndiagram/VENN_Util.java 7.14% <7.14%> (ø) 1 <1> (?)
...main/java/upb/ida/provider/VennDiagramHandler.java 7.69% <7.69%> (ø) 1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e216e7...09e52b7. Read the comment docs.

maqboolkhan commented 5 years ago

Hi @nikit91 kindly review and for my side this branch is ready to be merged 🚀