dice-group / ida-pg

GNU Affero General Public License v3.0

6 stars 4 forks source link

Pull request for test case of Cluster Algorithms #108

Closed nil9 closed 5 years ago

nil9 commented 5 years ago

update from master

codecov-io commented 5 years ago

Codecov Report

Merging #108 into master will not change coverage. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #108   +/-   ##
=========================================
  Coverage     43.24%   43.24%           
  Complexity      155      155           
=========================================
  Files            49       49           
  Lines          1274     1274           
  Branches        139      139           
=========================================
  Hits            551      551           
  Misses          684      684           
  Partials         39       39

Impacted Files	Coverage Δ	Complexity Δ
.../main/java/upb/ida/rest/MessageRestController.java	`52.94% <ø> (ø)`	`2 <0> (ø)`	:arrow_down:
...c/main/java/upb/ida/provider/DataDumpProvider.java	`100% <100%> (ø)`	`5 <5> (ø)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 411f25d...37e7425. Read the comment docs.

nil9 commented 5 years ago

@nikit91 @RicardoUsbeck, please review

RicardoUsbeck commented 5 years ago

please remove the System.out or convert them to propper logging methods

nil9 commented 5 years ago

@RicardoUsbeck Removed System.out

nikit-srivastava commented 5 years ago

@nil9 could you please check why the travis build is failing?

maqboolkhan commented 5 years ago

@himadri-kumari there is a merge conflict.

himadri-kumari commented 5 years ago

There seems like, this PR has a commit in which some test files have been deleted. Resolving the existing conflicts and merging this PR might delete those files from master as well. @nikit91 @Cortys @maqboolkhan please take a look at the below commit and let us know how to move ahead.

https://github.com/dice-group/ida/pull/108/commits/2689dcc1b6f38b850bc46b34307295545515575e

Below are the files deleted,

ida-ws/src/test/java/upb/ida/test/FileUtilTest.java
ida-ws/src/test/java/upb/ida/test/MessageRestControllerClusterTest.java
ida-ws/src/test/java/upb/ida/test/MessageRestControllerTest.java

Along with the above test files, some of the datasets in test folder also have been deleted.

nikit-srivastava commented 5 years ago

Hi @himadri-kumari, Out of the three files mentioned i see only one (MessageRestControllerTest.java) being deleted. Also, it seems like the travis build is failing.

As for the deleted files you would have to look a bit into what was that class testing, and if it is covered somewhere else now. If that is the case, then it can be safely deleted, otherwise not.

himadri-kumari commented 5 years ago

@nikit91 @Cortys @maq...please review the PR .