Open AsjadLFC opened 5 years ago
@maqboolkhan there is a problem with UI as it is uploading the file and also storing it in the required format but giving a false error.
Merging #111 into master will decrease coverage by
2.03%
. The diff coverage is8.62%
.
@@ Coverage Diff @@
## master #111 +/- ##
============================================
- Coverage 39.6% 37.56% -2.04%
- Complexity 132 134 +2
============================================
Files 48 53 +5
Lines 1212 1291 +79
Branches 134 140 +6
============================================
+ Hits 480 485 +5
- Misses 704 778 +74
Partials 28 28
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...a-ws/src/main/java/upb/ida/util/UploadManager.java | 0% <0%> (ø) |
0 <0> (?) |
|
...src/main/java/upb/ida/provider/LoadDsMetadata.java | 5.55% <0%> (-2.14%) |
1 <0> (ø) |
|
...-ws/src/main/java/upb/ida/constant/IDALiteral.java | 0% <0%> (ø) |
0 <0> (?) |
|
ida-ws/src/main/java/upb/ida/util/FileUtil.java | 32.85% <0%> (-0.97%) |
6 <0> (ø) |
|
...src/main/java/upb/ida/util/FileConversionUtil.java | 0% <0%> (ø) |
0 <0> (?) |
|
.../java/upb/ida/provider/RiveScriptBeanProvider.java | 100% <100%> (ø) |
2 <0> (ø) |
:arrow_down: |
.../main/java/upb/ida/rest/MessageRestController.java | 25.64% <100%> (-27.31%) |
2 <0> (ø) |
|
...ws/src/main/java/upb/ida/provider/ShowDataset.java | 11.11% <11.11%> (ø) |
1 <1> (?) |
|
.../src/main/java/upb/ida/provider/UploadDataset.java | 9.09% <9.09%> (ø) |
1 <1> (?) |
|
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3bc07ba...feefefc. Read the comment docs.
@AsjadLFC After recent commits by yo, problem of wrong message by UI has been solved itself 👍
cc @nikit91
@nikit91 the problems were resolved
@AsjadLFC please look into the codacy issues
@nikit codacy issues taken care of
closing and reopening issue because of codacy problem
for some reason codacy is not analyzing this pull request anymore
@AsjadLFC are you using your uni email to push the commits or is it personal one?
@nikit91 university mail
@AsjadLFC from what I can see, your commits are not linked to your github account, try configuring your local git author and email again
@AsjadLFC kindly resolve coflicts
@AsjadLFC kindly check and comment here if everything is still working fine Thanks then ill merge this PR
changed its title as there is alot to do with its integration with IDA
Tasks:
tested after integration also
This PR is on hold
Implementation of uniform dataset format with SPARQL endpoint created. Uploading of files done as general which converts them into turtle format. shows the available databases to the user as well. Integration is also completed with IDA.