dice-group / ida-pg

GNU Affero General Public License v3.0
6 stars 4 forks source link

Scraper cleanups #131

Closed Cortys closed 5 years ago

Cortys commented 5 years ago

This PR contains mainly three changes:

No new features or breaking changes.

codecov-io commented 5 years ago

Codecov Report

Merging #131 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #131   +/-   ##
========================================
  Coverage      39.6%   39.6%           
  Complexity      132     132           
========================================
  Files            48      48           
  Lines          1212    1212           
  Branches        134     134           
========================================
  Hits            480     480           
  Misses          704     704           
  Partials         28      28
Impacted Files Coverage Δ Complexity Δ
...c/main/java/upb/ida/provider/DataDumpProvider.java 100% <ø> (ø) 5 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3bc07ba...2032738. Read the comment docs.

Cortys commented 5 years ago

@maqboolkhan As discussed today, we merge this in first, then #120 and then change all other PRs to support the containerized architecture.

maqboolkhan commented 5 years ago

LGTM